pyaniz/Thursday
Watch
1
1
Fork
You've already forked Thursday
 0
Code Issues 30 Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix 1.37.2: the Resources icon opens the Resources tab of the description panel #91

Merged
pyaniz merged 1 commit from staging into main 2026-10-24 16:04:49 -05:00
Conversation 0 Commits 1 Files changed 8 +45 -54
pyaniz commented 2026-10-24 15:57:58 -05:00
Owner

Type: Fix (patch) - VERSION 1.37.1 -> 1.37.2.

Bug

The Resources icon (book) on collection rows and cards, and "Resources" in the 3-dot menu, opened the old standalone Resources dialog instead of the description panel's Resources tab.

Fix

  • GameDetailsDialog takes initialTab; its tab state is now keyed by tab name instead of position, so it can open on resources.
  • Collection page: the list row, grid card and gallery card get onOpenResources, which opens the panel on the Resources tab. The three components no longer render ResourceViewerDialog (their private dialog state is gone). Without the prop the icon / menu entry is hidden.
  • Lists page: same behaviour through a GameDetailsDialog of its own.
  • Left alone on purpose: the planner and dashboard still use ResourceViewerDialog, which also edits a scheduled session's links.

Testing

  • npm run build passes. Not exercised in a browser: please click the icon in list, grid and gallery views (and the 3-dot menu on a phone) and check the panel opens on Resources, also on the Lists page.

🤖 Generated with Claude Code

**Type:** Fix (patch) - VERSION 1.37.1 -> 1.37.2. ## Bug The Resources icon (book) on collection rows and cards, and "Resources" in the 3-dot menu, opened the old standalone Resources dialog instead of the description panel's Resources tab. ## Fix - `GameDetailsDialog` takes `initialTab`; its tab state is now keyed by tab name instead of position, so it can open on `resources`. - Collection page: the list row, grid card and gallery card get `onOpenResources`, which opens the panel on the Resources tab. The three components no longer render `ResourceViewerDialog` (their private dialog state is gone). Without the prop the icon / menu entry is hidden. - Lists page: same behaviour through a `GameDetailsDialog` of its own. - Left alone on purpose: the planner and dashboard still use `ResourceViewerDialog`, which also edits a scheduled session's links. ## Testing - `npm run build` passes. Not exercised in a browser: please click the icon in list, grid and gallery views (and the 3-dot menu on a phone) and check the panel opens on Resources, also on the Lists page. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Fix: the Resources icon opens the Resources tab of the description panel; remove the old window from the collection (1.37.2)
All checks were successful
Build and Publish Containers / build-and-push (push) Successful in 42s
Details
Mirror to GitHub / mirror (push) Successful in 30s
Details
c0e1d99e39 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
pyaniz merged commit 492518d19f into main 2026-10-24 16:04:49 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
audit

   
bug
Something is not working

  
cleanup

   
docs

   
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
new feature
This feature doesn't exist and needs to be created

  
P0

   
P1

   
P2

   
P3

   
question
More information is needed

  
roadmap
Tasks from the official roadmap

  
security

   
wontfix
This won't be fixed

No labels
audit
bug
cleanup
docs
duplicate
enhancement
help wanted
invalid
new feature
P0
P1
P2
P3
question
roadmap
security
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pyaniz/Thursday!91
No description provided.