pyaniz/Thursday
Watch
1
1
Fork
You've already forked Thursday
 0
Code Issues 30 Pull requests Projects Releases Packages 1 Wiki Activity Actions

Release 1.36.8: winner-only scoring, W/L results, unregistered players shown in ELO #86

Merged
pyaniz merged 2 commits from staging into main 2026-10-23 22:29:00 -05:00
Conversation 0 Commits 2 Files changed 14 +136 -49
pyaniz commented 2026-10-23 22:16:01 -05:00
Owner

Type: Fix (patch) - VERSION 1.36.6 -> 1.36.7.

What

  • New scoring mode winner (third toggle next to Points / Ranking in the record-play form): exactly one winner, everybody else loses. Validated ("Pick the winner: exactly one player"); the trophy button is an exclusive pick.
  • Scores become W / L for plays without a score: winner-only plays and co-op games (all W when the team won, all L otherwise). The Points / Ranking toggle is hidden for co-op games, which are stored with scoring_type = 'winner'.
  • ELO: finishing_order handles winner explicitly (winner 1st, the rest share 2nd; no winner flagged = nothing to rate). Two new unit tests (24 total).
  • Display: Play History uses "Result" and "one winner, the rest lose" for these plays; the dashboard score formatter no longer prints NaN for non-numeric scores.
  • Existing plays are untouched; editing an old co-op play saves W / L.

Testing

  • 24 engine unit tests and npm run build pass. Not run against a database or in a browser. On staging please check: record a Winner play in a group of 4 (1 W, 3 L), a co-op win and a co-op loss, edit an old co-op play, and how they read in Play History and the dashboard.

🤖 Generated with Claude Code

**Type:** Fix (patch) - VERSION 1.36.6 -> 1.36.7. ## What - **New scoring mode `winner`** (third toggle next to Points / Ranking in the record-play form): exactly one winner, everybody else loses. Validated ("Pick the winner: exactly one player"); the trophy button is an exclusive pick. - **Scores become `W` / `L`** for plays without a score: winner-only plays and **co-op games** (all W when the team won, all L otherwise). The Points / Ranking toggle is hidden for co-op games, which are stored with `scoring_type = 'winner'`. - **ELO**: `finishing_order` handles `winner` explicitly (winner 1st, the rest share 2nd; no winner flagged = nothing to rate). Two new unit tests (24 total). - **Display**: Play History uses "Result" and "one winner, the rest lose" for these plays; the dashboard score formatter no longer prints `NaN` for non-numeric scores. - Existing plays are untouched; editing an old co-op play saves W / L. ## Testing - 24 engine unit tests and `npm run build` pass. Not run against a database or in a browser. On staging please check: record a Winner play in a group of 4 (1 W, 3 L), a co-op win and a co-op loss, edit an old co-op play, and how they read in Play History and the dashboard. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Fix: winner-only scoring mode and W / L results for co-op and score-less plays (1.36.7)
All checks were successful
Build and Publish Containers / build-and-push (push) Successful in 40s
Details
Mirror to GitHub / mirror (push) Successful in 19s
Details
4eba24127e 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
pyaniz changed title from Fix 1.36.7: winner-only scoring and W / L results to Release 1.36.8: winner-only scoring, W/L results, unregistered players shown in ELO 2026-10-23 22:22:10 -05:00
Fix: list players without an account on ELO leaderboards in red italics (1.36.8)
All checks were successful
Build and Publish Containers / build-and-push (push) Successful in 41s
Details
Mirror to GitHub / mirror (push) Successful in 18s
Details
453bff2971 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
pyaniz merged commit d53321b515 into main 2026-10-23 22:29:00 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
audit

   
bug
Something is not working

  
cleanup

   
docs

   
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
new feature
This feature doesn't exist and needs to be created

  
P0

   
P1

   
P2

   
P3

   
question
More information is needed

  
roadmap
Tasks from the official roadmap

  
security

   
wontfix
This won't be fixed

No labels
audit
bug
cleanup
docs
duplicate
enhancement
help wanted
invalid
new feature
P0
P1
P2
P3
question
roadmap
security
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pyaniz/Thursday!86
No description provided.