pyaniz/Thursday

Watch

Fork 0

Release 1.36.6: ELO guests, no-account players rated, player plays list #85

Merged

pyaniz merged 2 commits from staging into main

2026-10-23 21:53:44 -05:00

pyaniz commented

2026-10-23 21:38:14 -05:00

Owner

Type: Fix (patch) - VERSION 1.36.4 -> 1.36.5.

What

Everyone in a rated play is rated, including players without an account (user_id null). Their results now move their opponents' ratings; before they were left out of the calculation.
Leaderboards list registered players only. A group lists its registered members plus registered players who played in the group's plays without being members; those get a Guest chip (Rankings page, dashboard card, per-game ranking in the game panel). Players without an account are never listed anywhere.
The player chart endpoint accepts anyone the leaderboard lists (members and guests), otherwise 404.
Wording in the help dialog, notes, record-play checkbox helper and docs/features/Ratings.md updated.

Notes for review

Play History still shows the rating change next to every participant of a play you can read, including players without an account.
Engine untouched (22 unit tests pass); the change is in features/ratings/router.py (_load_plays, new _listed_players) and the UI.

Testing

22 engine unit tests, npm run build and Python compile pass. Not run against a database or in a browser. On staging please check: a play with a no-account player changes the registered players' ratings but that player is not listed; a registered non-member who played in the group is listed with a Guest chip.

🤖 Generated with Claude Code

**Type:** Fix (patch) - VERSION 1.36.4 -> 1.36.5. ## What - **Everyone in a rated play is rated**, including players without an account (`user_id` null). Their results now move their opponents' ratings; before they were left out of the calculation. - **Leaderboards list registered players only.** A group lists its registered members plus registered players who played in the group's plays without being members; those get a **Guest** chip (Rankings page, dashboard card, per-game ranking in the game panel). Players without an account are never listed anywhere. - The player chart endpoint accepts anyone the leaderboard lists (members and guests), otherwise 404. - Wording in the help dialog, notes, record-play checkbox helper and `docs/features/Ratings.md` updated. ## Notes for review - Play History still shows the rating change next to every participant of a play you can read, including players without an account. - Engine untouched (22 unit tests pass); the change is in `features/ratings/router.py` (`_load_plays`, new `_listed_players`) and the UI. ## Testing - 22 engine unit tests, `npm run build` and Python compile pass. Not run against a database or in a browser. On staging please check: a play with a no-account player changes the registered players' ratings but that player is not listed; a registered non-member who played in the group is listed with a Guest chip. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

pyaniz added 1 commit

2026-10-23 21:38:14 -05:00

Fix: rate players without an account, label non-member players as guests on leaderboards (1.36.5)

Build and Publish Containers / build-and-push (push) Successful in 41s

Details

Mirror to GitHub / mirror (push) Successful in 17s

Details

adfcc41412

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

pyaniz changed title from ~~Fix 1.36.5: rate players without an account, show non-member players as guests~~ to Release 1.36.6: ELO guests, no-account players rated, player plays list

2026-10-23 21:46:49 -05:00

pyaniz added 1 commit

2026-10-23 21:46:50 -05:00

Fix: player plays list in Rankings with paging, play details for plays you took part in (1.36.6)

Build and Publish Containers / build-and-push (push) Successful in 40s

Details

Mirror to GitHub / mirror (push) Successful in 18s

Details

afc353b071

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

pyaniz merged commit e1ddc99859 into main

2026-10-23 21:53:44 -05:00

pyaniz referenced this pull request from a commit

2026-10-23 21:53:46 -05:00

Merge pull request 'Release 1.36.6: ELO guests, no-account players rated, player plays list' (#85) from staging into main

No reviewers

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

pyaniz/Thursday!85

No description provided.

Rows
Columns